@Marek Bachmann @Friendica Entwickler Marek is it from an iPhone, I can remember that iPhones often have the wrong orientation of the photo, I had this a lot with photos my sister send me by Signal. She has an iPhone.
Thanks for bringing this up, but it is not from an IPhone. I guess it is an issue in our backend introduced eventually between last stable a current develop since on the last stable the problem does not occur, cf. friendica.mbbit.de/photos/mare… (current dev) and kassel.social/photos/marek/alb… (stable)
They are portraits for me when I click them. Desktop + Browser. My instance uses the Frio theme + some custom CSS on top that should not affect how these photos are displayed. idk if that's the sort of input you were looking for.
Thank you very much. As @Hypolite Petovan mentioned, it is high likely that something goes wrong with the small thumbnail generation.
What would also help me if this someone else / other instances face this issue. Instances need to run on the latest dev branch, since in the current stable I do not face this issue neither.
So if someone on a dev instance might try to upload a portrait photo and tell me if the problem also occurs, I will create a new issue for this phenom on git.
@Hypolite Petovan a general question which surely is in the scope of your expertise: Is there some method in git to check when a specific method / code block was last changed by a commit? In this specific case, I would like to check when and what was changed in the Images::getScalingDimensions($width, $height, 90); method to confirm / rule out being the cause of this bug.
@Marek Bachmann It’s a common criticism of the name of the feature, several alternatives have been suggested but there’s little chance any of them will be adopted.
utzer [Friendica]
in reply to Marek Bachmann • • •Friendica Developers reshared this.
Marek Bachmann
in reply to utzer [Friendica] • • •I guess it is an issue in our backend introduced eventually between last stable a current develop since on the last stable the problem does not occur, cf.
friendica.mbbit.de/photos/mare… (current dev) and
kassel.social/photos/marek/alb… (stable)
utzer [Friendica] likes this.
Marek Bachmann
in reply to Marek Bachmann • • •Please review my shared dev post directly
directly to see additional issue description.
Tio
in reply to Marek Bachmann • •like this
Hypolite Petovan, Marek Bachmann and Mark like this.
Friendica Developers reshared this.
Hypolite Petovan
in reply to Tio • • •utzer [Friendica] likes this.
Friendica Developers reshared this.
Tio
in reply to Hypolite Petovan • •They are squashed into a square shape. But when I click them they look proper:
Marek Bachmann likes this.
Friendica Developers reshared this.
Hypolite Petovan
in reply to Tio • • •like this
Marek Bachmann and Tio like this.
Friendica Developers reshared this.
Marek Bachmann
in reply to Tio • • •Thank you very much. As @Hypolite Petovan mentioned, it is high likely that something goes wrong with the small thumbnail generation.
What would also help me if this someone else / other instances face this issue.
Instances need to run on the latest dev branch, since in the current stable I do not face this issue neither.
So if someone on a dev instance might try to upload a portrait photo and tell me if the problem also occurs, I will create a new issue for this phenom on git.
Friendica Developers reshared this.
Marek Bachmann
in reply to Marek Bachmann • • •In this specific case, I would like to check when and what was changed in the
Images::getScalingDimensions($width, $height, 90);method to confirm / rule out being the cause of this bug.Friendica Developers reshared this.
Hypolite Petovan
in reply to Marek Bachmann • • •git blame, although I’ve never used it in command line. In PHPStorm, it’s called “Annotate with git blame”.Marek Bachmann likes this.
Friendica Developers reshared this.
Marek Bachmann
in reply to Hypolite Petovan • • •Hypolite Petovan likes this.
Friendica Developers reshared this.
Marek Bachmann
in reply to Hypolite Petovan • • •Hypolite Petovan likes this.
Friendica Developers reshared this.
Marek Bachmann
in reply to Hypolite Petovan • • •Hypolite Petovan likes this.
Friendica Developers reshared this.
Hypolite Petovan
in reply to Marek Bachmann • • •Marek Bachmann likes this.
Friendica Developers reshared this.